Skip to content

Fix KBART export to prefer electronic ISSN in journal URLs#81

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/update-url-revista-sanidad
Draft

Fix KBART export to prefer electronic ISSN in journal URLs#81
Copilot wants to merge 3 commits intomasterfrom
copilot/update-url-revista-sanidad

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

KBART export was generating invalid URLs for journals that transitioned from print to electronic-only. The journal "Revista española de sanidad penitenciaria" in SciELO Spain now uses electronic ISSN 2013-6463 but the export still referenced the obsolete print ISSN 1575-0620 in URLs, resulting in 404s.

Changes

  • export/kbart.py: Added _generate_journal_url() method that uses journal.any_issn(priority='electronic') instead of journal.scielo_issn
  • export/kbart.py: Updated fmt_csv() to call new method instead of data.url().replace('sci_serial', 'sci_issues')
  • tests/test_kbart.py: Added unit tests for URL generation logic

Technical Details

The original code relied on data.url() from xylose, which uses scielo_issn (v400 field) that may contain the print ISSN for legacy journals. The fix leverages xylose's existing any_issn() method with electronic priority:

def _generate_journal_url(self, journal, language='en'):
    issn = journal.any_issn(priority=u'electronic')
    if journal.scielo_domain and issn:
        return "http://{0}/scielo.php?script=sci_issues&pid={1}&lng={2}".format(
            journal.scielo_domain, issn, language
        )
    return ''

This ensures correct ISSN selection while maintaining backward compatibility—journals with only print ISSN continue to work as before.

Original prompt

This section details on the original issue you should resolve

<issue_title>Atualizar a URL do periódico "Revista española de sanidad penitenciaria" de SciELO Espanha no KBART</issue_title>
<issue_description>No KBART da coleção SciELO Espanha, a URL do periódico “Revista española de sanidad penitenciaria” utiliza o ISSN da versão impressa na URL. Porém o periódico deixou de usar o ISSN impresso e isso foi alterado na coleção SciELO Espanha, mas não reflete na URL informada no KBART, ocasionando erro de acesso à página dos periódicos nas bases de dados.

URL no KBART: http://scielo.isciii.es/scielo.php?nrm=iso&pid=1575-0620&lng=&script=sci_issues
URL válida: http://scielo.isciii.es/scielo.php?nrm=iso&pid=2013-6463&lng=&script=sci_issues</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 3, 2026 20:35
Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Update URL for 'Revista española de sanidad penitenciaria' in KBART Fix KBART export to prefer electronic ISSN in journal URLs Feb 3, 2026
Copilot AI requested a review from robertatakenaka February 3, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atualizar a URL do periódico "Revista española de sanidad penitenciaria" de SciELO Espanha no KBART

2 participants