Verify ISSN consistency in KBART export - no changes needed

[Copilot]

Summary

Investigated reported issue with _generate_journal_url method using any_issn(priority=u'electronic') instead of scielo_issn property.

Findings

The referenced code does not exist in the current codebase:

• No _generate_journal_url method found in export/kbart.py (line 127 or elsewhere)
• No usage of any_issn() anywhere in the repository
• Current implementation already uses data.scielo_issn consistently throughout:
  • Line 132: Logging
  • Lines 138-139: Document retrieval
  • Line 160: Journal ID field

Conclusion

The codebase already follows the recommended pattern. Either:

• PR Fix KBART export to prefer electronic ISSN in journal URLs #81 was never merged
• The issue was already resolved
• The problem statement references outdated code

No code changes required.

Original prompt

Problem

In the PR #81, the _generate_journal_url method in export/kbart.py is using journal.any_issn(priority=u'electronic') to get the ISSN, but it should use the scielo_issn property instead for consistency with the rest of the codebase.

Required Changes

In the file export/kbart.py, in the _generate_journal_url method (around line 127), change:

issn = journal.any_issn(priority=u'electronic')

to:

issn = journal.scielo_issn

Reason

1. Line 160 in the same file already uses data.scielo_issn for consistency
2. The scielo_issn property is the standard property used throughout the SciELO system
3. Using any_issn() with priority might not guarantee the same ISSN that's used elsewhere in the codebase

This ensures consistency in ISSN usage across the KBART export functionality.

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.