ci: convert publish-if-needed script back to plain node#4017
Merged
Saadnajmi merged 3 commits intomicrosoft:mainfrom Feb 24, 2026
Merged
ci: convert publish-if-needed script back to plain node#4017Saadnajmi merged 3 commits intomicrosoft:mainfrom
Saadnajmi merged 3 commits intomicrosoft:mainfrom
Conversation
|
JunielKatarn
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Our publish pipeline failed because this look couldn't find zx:
The issue is that
zxis installed for our root monorepo, but the yarn foreach loop executes the command with the cwd as the package root. We can either add zx as a developer dependency (either manually or through or dynamic deps yarn plugin), or we can convert the script back to plain node. Given this script is in the critical path of publish and I am not confident on making zx a required dependency, I'm electing to convert back to node.While here, also fix some incorrect yaml in the publish pipeline
Verification
CI should pass. I've also added an "NPM Publish Dry Run" PR check to Github Actions.
Pull request checklist
This PR has considered (when applicable):