Skip to content

Conversation

@bennthomsen
Copy link

Summary

Extends the Tektronix DPO7200xx oscilloscope driver with acquisition control, cursor measurements, and immediate
measurement capabilities.

New Modules

  • TektronixDPOAcquisition: Controls acquisition mode (sample, peakdetect, average, high_res,
    envelope), state (ON/OFF/RUN/STOP), and stop conditions
  • TektronixDPOCursor: Cursor positioning for voltage/time measurements with x1/x2 (seconds) and y1/y2 (volts)
    positions
  • TektronixDPOMeasurementImmediate: Immediate measurement functionality with configurable sources and gating

Enhancements

  • TektronixDPOTrigger: Added ready, state, and level parameters
  • TektronixDPOChannel: Added coupling parameter (AC, DC, DCREJECT, GND)
  • Added type annotations for all submodules

Checklist

  • Short description included
  • Inline docstrings provided
  • Newsfragment to be added after PR number assigned

- Add hold parameter for channel output condition during wait-for-trigger
- Add force_jump parameter for sequence jumping
- Add set_event_jump method for event-based sequence control
- Add TektronixDPOAcquisition module (mode, state, stop_after)
- Add TektronixDPOCursor module (function, state, x1/x2/y1/y2 positions)
- Add TektronixDPOMeasurementImmediate module
- Enhance TektronixDPOTrigger (ready, state, level parameters)
- Enhance TektronixDPOChannel (coupling parameter)
- Add type annotations for submodules
@bennthomsen bennthomsen requested a review from a team as a code owner February 3, 2026 10:10
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.93%. Comparing base (3f970d5) to head (4ccfc5c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/qcodes/instrument_drivers/tektronix/DPO7200xx.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7838      +/-   ##
==========================================
+ Coverage   59.87%   59.93%   +0.06%     
==========================================
  Files         352      352              
  Lines       31872    31920      +48     
==========================================
+ Hits        19083    19131      +48     
  Misses      12789    12789              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astafan8
Copy link
Contributor

astafan8 commented Feb 4, 2026

@bennthomsen see also Ci failure - pre-commit hooks need to be run for formatting/linting

@bennthomsen
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments otherwise ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants