Skip to content

Conversation

@bennthomsen
Copy link
Contributor

@bennthomsen bennthomsen commented Feb 3, 2026

Summary

Adds sequence control functionality to the Tektronix AWG70000A driver for improved waveform sequencing.

Changes

  • hold parameter: Controls the output condition of a channel while the instrument is in the
    waiting-for-trigger state. Options: ZERO (0V) or FIRST (first value of next sequence)
  • force_jump parameter: Forces an immediate jump to a specified step in the sequence (1-16383)
  • set_event_jump() method: Configures event-based jumps within a sequence, allowing dynamic sequence control

Checklist

  • Short description included
  • Inline docstrings provided
  • Newsfragment to be added after PR number assigned

- Add hold parameter for channel output condition during wait-for-trigger
- Add force_jump parameter for sequence jumping
- Add set_event_jump method for event-based sequence control
- Add TektronixDPOAcquisition module (mode, state, stop_after)
- Add TektronixDPOCursor module (function, state, x1/x2/y1/y2 positions)
- Add TektronixDPOMeasurementImmediate module
- Enhance TektronixDPOTrigger (ready, state, level parameters)
- Enhance TektronixDPOChannel (coupling parameter)
- Add type annotations for submodules
@bennthomsen bennthomsen requested a review from a team as a code owner February 3, 2026 10:09
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.93%. Comparing base (3bf10d8) to head (ec75485).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...c/qcodes/instrument_drivers/tektronix/AWG70000A.py 87.50% 1 Missing ⚠️
...c/qcodes/instrument_drivers/tektronix/DPO7200xx.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
+ Coverage   59.87%   59.93%   +0.06%     
==========================================
  Files         352      352              
  Lines       31872    31927      +55     
==========================================
+ Hits        19083    19137      +54     
- Misses      12789    12790       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennthomsen
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@jenshnielsen
Copy link
Collaborator

@bennthomsen It looks like both this and #7838 now holds improvements for both instruments. Should we merge one of them and close the other?

@bennthomsen
Copy link
Contributor Author

bennthomsen commented Feb 11, 2026

@bennthomsen It looks like both this and #7838 now holds improvements for both instruments. Should we merge one of them and close the other?

Arrr what an idiot I am. I have a combined branch that I merge both of these into for joint testing. But must have been on the wrong branch when merging at some stage.

Will abandon this one

@jenshnielsen
Copy link
Collaborator

@benn-thomsen No worries as long as there is a changelog entry for both drivers all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants