Only set proxy environment variables in proxy environments #71
Conversation
| # Unset proxy variables for all login shells | ||
| COPY unset-proxy.sh /etc/bash_completion.d/unset-proxy.sh |
There was a problem hiding this comment.
is this script still needed? My expectation is that this Dockerfile is only used in cases where proxy variables are actually set.
There was a problem hiding this comment.
Yes, the script is only needed where proxy variables are used
lurtz
requested review from
olivembo and
opajonk
and removed request for
opajonk
lurtz
force-pushed
the
only-set-proxy-variables-if-needed
branch
2 times, most recently
from
6858bb6 to
aa93b25
Compare
| "build": { | ||
| // Installs latest version from the Distribution | ||
| "dockerfile": "./Dockerfile", | ||
| "dockerfile": "./${localEnv:DEVCONTAINER_DOCKERFILE_NAME:Dockerfile}", |
There was a problem hiding this comment.
Are you sure this works as expected? I think this will kick in only during pre-building of the container, in GitHub Actions. And there, proxy variables are never set.
There was a problem hiding this comment.
IMHO the current / main solution works the same. Environment variables are set in the pre-built image and are taken from the build environment. As such I expect at the moment the people using the devcontainer in environments with a proxy will have to build the devcontainer themselves.
I guess an alternative is to use env files: https://code.visualstudio.com/remote/advancedcontainers/environment-variables#_option-2-use-an-env-file
lurtz
force-pushed
the
only-set-proxy-variables-if-needed
branch
4 times, most recently
from
e8eb525 to
51c5bf6
Compare
The approach using /etc/profile.d/ to unset empty variables does not work, because it is never executed in the devcontainer. The proposed solution should be more robust, because now the variables are never present, if not needed and the build will fail, if it is broken. Files in /etc/bash_completion.d/ will be executed whenever a new bash instance is spawned and should work as a /etc/profile.d/ replacement.
lurtz
force-pushed
the
only-set-proxy-variables-if-needed
branch
from
51c5bf6 to
ffcf6ed
Compare
3 participants
The approach using
/etc/profile.d/to unset empty variables does not work, because it is never executed in the devcontainer.The proposed solution should be more robust, because now the variables are never present, if not needed and the build will fail, if it is broken. Files in
/etc/bash_completion.d/will be executed whenever a new bash instance is spawned and should work as a/etc/profile.d/replacement.Caused by #52