Check scripts with shellcheck #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurtz
commented
Jan 30, 2026
src/s-core-devcontainer/.devcontainer/bazel-feature/install_matching_bazel_version.sh
Show resolved
Hide resolved
lurtz
commented
Jan 30, 2026
lurtz
force-pushed
the
check-scripts-with-shellcheck
branch
2 times, most recently
from
a95298a to
417a89e
Compare
opajonk
suggested changes
Feb 2, 2026
src/s-core-devcontainer/.devcontainer/bazel-feature/install_matching_bazel_version.sh
Outdated
Show resolved
Hide resolved
lurtz
force-pushed
the
check-scripts-with-shellcheck
branch
from
07c5fce to
b3c83e2
Compare
lurtz
force-pushed
the
check-scripts-with-shellcheck
branch
from
b3c83e2 to
3c7a49d
Compare
opajonk
approved these changes
Feb 3, 2026
|
|
||
| # Unset proxy variables for all login shells | ||
| COPY unset-proxy.sh /etc/profile.d/unset-proxy.sh | ||
| RUN chmod +x /etc/profile.d/unset-proxy.sh |
Contributor
Author
There was a problem hiding this comment.
yes, because due to the added shebang shellcheck also enforces that the script is executable, which it was not before
Contributor
Author
There was a problem hiding this comment.
anyway I discovered the script is actually never executed and hence we have #71
FScholPer
approved these changes
Feb 3, 2026
AlexanderLanin
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devcontainer uses some shellscripts for which static code analysis was missing so far. This adds static code analysis using shellcheck and fixes almost all findings.