-
Notifications
You must be signed in to change notification settings - Fork 10
Add ARM Support #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add ARM Support #1229
Conversation
Greptile OverviewGreptile SummaryThis PR adds ARM (aarch64) Linux support by introducing the Key changes:
Issues identified:
Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Additional Comments (1)
This lock change removes the |
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
| "opencv-python", | ||
| "open3d", | ||
| "open3d-unofficial-arm; platform_machine == 'aarch64' and platform_system == 'Linux'", | ||
| "open3d>=0.18.0; platform_machine != 'aarch64' or platform_system != 'Linux'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OR logic will install open3d on Linux x86_64 since platform_system != 'Linux' evaluates to False but platform_machine != 'aarch64' evaluates to True, making the overall condition True.
| "open3d>=0.18.0; platform_machine != 'aarch64' or platform_system != 'Linux'", | |
| "open3d>=0.18.0; platform_machine != 'aarch64' or platform_system != 'Linux'", |
Should use AND to exclude only Linux aarch64:
| "open3d>=0.18.0; platform_machine != 'aarch64' or platform_system != 'Linux'", | |
| "open3d>=0.18.0; not (platform_machine == 'aarch64' and platform_system == 'Linux')", |
test on an Arm system with:
Just uses the stop-gap pypi package published at: https://github.com/jeff-hykin/open3d_jetson
Which is just pre-build wheel files for arm based on the open3d repo