Skip to content

fix: use strict hostname check for GitHub URLs in OSS sponsorship router #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiloconnect wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use strict hostname check for GitHub URLs in OSS sponsorship router #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/routers/admin/oss-sponsorship-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,23 @@ import { TRPCError } from '@trpc/server';
import { getIntegrationForOrganization } from '@/lib/integrations/db/platform-integrations';
import { getAgentConfig } from '@/lib/agent-config/db/agent-configs';

/**
* Validate that a URL is strictly a GitHub.com URL.
* Rejects lookalike hostnames like github.com.evil.com.
*/
function isStrictGitHubUrl(url: string): boolean {
try {
const parsed = new URL(url);
return parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com';
Copy link
Contributor Author

@kiloconnect kiloconnect bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING]: isStrictGitHubUrl() allows non-HTTPS GitHub URLs

If this URL is ever used as a clickable link (emails, UI, logs), allowing http: increases exposure to downgrade/MITM. Consider requiring https: in addition to the strict hostname check.

Suggested change
return parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com';
return parsed.protocol === 'https:' && (parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com');

} catch {
return false;
}
}

const OssCsvRowSchema = z.object({
githubUrl: z.string().url(),
githubUrl: z.string().url().refine(isStrictGitHubUrl, {
message: 'URL must be a github.com URL',
}),
email: z.string().email(),
creditsDollars: z.number().nonnegative(),
tier: z.union([z.literal(1), z.literal(2), z.literal(3)]),
Expand All @@ -47,7 +62,7 @@ function escapeIlikePattern(str: string): string {
function extractRepoNameFromUrl(githubUrl: string): string | null {
try {
const parsed = new URL(githubUrl);
if (!parsed.hostname.includes('github.com')) {
if (parsed.hostname !== 'github.com' && parsed.hostname !== 'www.github.com') {
return null;
}
const pathParts = parsed.pathname.split('/').filter(Boolean);
Expand Down