fix: use strict hostname check for GitHub URLs in OSS sponsorship router#272
Open
kiloconnect[bot] wants to merge 1 commit intomainfrom
Open
fix: use strict hostname check for GitHub URLs in OSS sponsorship router#272kiloconnect[bot] wants to merge 1 commit intomainfrom
kiloconnect[bot] wants to merge 1 commit intomainfrom
Conversation
Replace loose .includes('github.com') check with exact hostname
comparison to prevent lookalike domains like github.com.evil.com.
Add isStrictGitHubUrl validator and apply it as a Zod refinement
on the CSV row schema.
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| function isStrictGitHubUrl(url: string): boolean { | ||
| try { | ||
| const parsed = new URL(url); | ||
| return parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com'; |
Contributor
Author
There was a problem hiding this comment.
[WARNING]: isStrictGitHubUrl() allows non-HTTPS GitHub URLs
If this URL is ever used as a clickable link (emails, UI, logs), allowing http: increases exposure to downgrade/MITM. Consider requiring https: in addition to the strict hostname check.
Suggested change
| return parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com'; | |
| return parsed.protocol === 'https:' && (parsed.hostname === 'github.com' || parsed.hostname === 'www.github.com'); |
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace loose
.includes('github.com')check with exact hostname comparison to prevent lookalike domains likegithub.com.evil.com.Changes
isStrictGitHubUrl()function that validates URLs via exact hostname comparison (github.com/www.github.com).refine()on the CSV row schema'sgithubUrlfield.includes('github.com')check inextractRepoNameFromUrl()with strict hostname equality