Add configurable TLS certificate verification and fix port handling#238
Open
Add configurable TLS certificate verification and fix port handling#238
Conversation
- Add `Proxy.certificate_check` setting (defaults to true for secure production) - Add `compute_host_header()` to properly format Host header with non-standard ports - Extend `ensure_origin_backend()` with certificate_check parameter - Include cert setting in backend name to avoid reusing backends with different settings - Add comprehensive tests for port preservation in proxy signing and HTML rewriting - Update all call sites to pass certificate_check=true (secure default) This fixes an issue where backends behind reverse proxies would generate URLs without the port when the Host header didn't include it.
4 tasks
This was referenced Feb 5, 2026
aram356
added
enhancement
…roxy components. Updated related settings and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proxy.certificate_checksetting to control TLS certificate verification (defaults totruefor secure production use, set tofalsefor local development with self-signed certs)compute_host_header()function to properly format Host header with non-standard ports, fixing an issue where backends behind reverse proxies would generate URLs without the portensure_origin_backend()API withcertificate_checkparameterTest plan
cargo checkpassescargo test -p trusted-server-commonpasses:9443) preserve the port in signed URLscertificate_check = falsein local dev with self-signed certsCloses #246
Related to #179