Add IntegrationHeadInjector trait for head script injection#239
Draft
aram356 wants to merge 1 commit intofeature/cert-verification-port-handlingfrom
Draft
Add IntegrationHeadInjector trait for head script injection#239aram356 wants to merge 1 commit intofeature/cert-verification-port-handlingfrom
aram356 wants to merge 1 commit intofeature/cert-verification-port-handlingfrom
Conversation
- Add `IntegrationHeadInjector` trait allowing integrations to inject HTML into <head> - Add `with_head_injector()` builder method to IntegrationRegistrationBuilder - Add `head_inserts()` method to IntegrationRegistry to collect all injector snippets - Update html_processor to inject integration head inserts after TSJS bundle This enables integrations like GAM to inject configuration scripts into the document head without modifying the main TSJS bundle.
4 tasks
aram356
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntegrationHeadInjectortrait allowing integrations to inject HTML snippets into<head>with_head_injector()builder method toIntegrationRegistrationBuilderhead_inserts()method toIntegrationRegistryto collect all injector snippetshtml_processorto inject integration head inserts after the TSJS bundleThis enables integrations (like the upcoming GAM interceptor) to inject configuration scripts into the document head without modifying the main TSJS bundle.
Test plan
cargo checkpassescargo test -p trusted-server-commonpasses<head>Dependencies
Closes #247
Related to #179