Skip to content

Remove non-ZCL siren select entities for basic sirens#666

Draft
TheJulianJES wants to merge 2 commits intozigpy:devfrom
TheJulianJES:tjj/siren_select_feature
Draft

Remove non-ZCL siren select entities for basic sirens#666
TheJulianJES wants to merge 2 commits intozigpy:devfrom
TheJulianJES:tjj/siren_select_feature

Conversation

@TheJulianJES
Copy link
Contributor

DRAFT. TODO: Move "siren_basic" string as constant to zha-quirks, so we can later import it.

Proposed change

This removes the non-ZCL select entities created for sirens IF they hint "siren_basic" as an "exposed feature" from quirks.

This is done by adding not_exposed_features to discovery. This might also come in handy for future entities. This was one of the suggested options to achieve this from the PR linked below.

Other options would have included overriding is_supported in all three classes to ignore based on the exposed features OR creating three more classes and making use of feature_priority to always return False for is_supported in the basic siren ZCL select entities. IMO, the not_exposed_features is cleaner and "fine".

Additional information

Related (and see for more description):

@TheJulianJES TheJulianJES mentioned this pull request Feb 21, 2026
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.43%. Comparing base (aa03919) to head (9e4f067).

Files with missing lines Patch % Lines
zha/application/discovery.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #666      +/-   ##
==========================================
- Coverage   97.44%   97.43%   -0.01%     
==========================================
  Files          62       62              
  Lines       10731    10734       +3     
==========================================
+ Hits        10457    10459       +2     
- Misses        274      275       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant