Skip to content

Fixed Graph staying on page after removing from encoding shelf #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mawerb wants to merge 2 commits into
base: main-mawerb
Choose a base branch
from
Open

Fixed Graph staying on page after removing from encoding shelf #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef4427b
Fixed Graph staying on page after removing from encoding shelf
mawerb Jan 9, 2026
b9eea6f
Revert unnecessary changes to package-lock.json, AppContext.tsx and C…
mawerb Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions src/components/ChartView/ChartView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ export function ChartView() {
</p>
</div>
</div>
) : !spec ? (
) : !spec && (
<div
style={{
flex: 1,
Expand Down Expand Up @@ -342,25 +342,24 @@ export function ChartView() {
</p>
</div>
</div>
) : (
<div
ref={containerRef}
style={{
flex: 1,
backgroundColor: 'var(--color-bg-secondary)',
borderRadius: '16px',
padding: '24px',
border: '1px solid var(--color-border)',
position: 'relative',
zIndex: 1,
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
animation: 'fadeIn 0.4s ease-out',
overflow: 'hidden',
}}
/>
)}
<div
ref={containerRef}
style={{
flex: 1,
backgroundColor: 'var(--color-bg-secondary)',
borderRadius: '16px',
padding: '24px',
border: '1px solid var(--color-border)',
position: 'relative',
zIndex: 1,
display: spec ? 'flex' : 'none', // Hide the div when there is no graph
alignItems: 'center',
justifyContent: 'center',
animation: spec ? 'fadeIn 0.4s ease-out' : 'none', // Disable animation when hidden
overflow: 'hidden',
}}
/>

{/* Footer gradient line */}
<div
Expand Down