Update PHP and PHPDoc grammars #89
Conversation
To v0.24.2 and v0.1.7 respectively. Enables features of PHP 8.4 and 8.5. - tree-sitter/tree-sitter-php#275 - `php_end_tag` was added - `callable` is no longer a keyword - tree-sitter/tree-sitter-php#237 - `string_value` was replaced with `string_content` - `modifier` field was removed from `class_declaration` - Various - `yield` and `from` are converted to `yield` and `yield from`
|
We require contributors to sign our Contributor License Agreement, and we don't have @Roardom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Roardom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
| modifier: (_)? @_modifier | ||
| (#not-eq? @_modifier "abstract") | ||
| (_)* @_modifier | ||
| (#not-any-eq? @_modifier "abstract") | ||
| . |
There was a problem hiding this comment.
I'm not entirely sure about this change. The grammar no longer defines a modifier field, but does this instead:
I don't use runnables nor phpunit so not sure where to look to make sure the queries are correct.
|
fixes #86 |
|
Converted to draft as the phpdoc grammar is still receiving some fixes for the latest php grammar version and might have to be updated some more. |
MrSubidubi
changed the title
|
Hey, thanks for the PR! We'd love to have this, is there any update on the upstream grammar fixes? |
MrSubidubi
added
the
awaiting info
|
Honestly I've been using these grammars locally for the past month and haven't noticed any issues (I might just be looking in the wrong place). I can take a look at rebasing this branch later today. |
|
That would be awesome, thanks! |
MrSubidubi
removed
the
awaiting info
2 participants
To v0.24.2 and v0.1.7 respectively. Enables features of PHP 8.4 and 8.5.
php_end_tagwas addedcallableis no longer a keywordstring_valuewas replaced withstring_contentmodifierfield was removed fromclass_declarationyieldandfromare converted toyieldandyield from