-
-
Notifications
You must be signed in to change notification settings - Fork 377
Add benchmarks for sharded + local store indexing #3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add benchmarks for sharded + local store indexing #3663
Conversation
Parameterize with shards and no shards. Parameterize with local + memory store to have an example of a store which has some modest latency.
|
if we want more control over the latency, we could wrap memory storage with a |
|
@d-v-b go ahead! If you make it I can't be accused of juicing my numbers by picking high latencies ;p In all seriousness, that would be quite useful for picking a good default coalesce_max_gap_bytes. |
Parameterize with shards and no shards. Also parameterize with local + memory store to have an example of a store which has some modest latency.
When testing performance of optimizing sharded zarr reads I found that the memory store is too fast to show any difference, but the local store makes performance improvements there very visible. The extra parameterizations do expand the test space; test_slice_indexing with benchmarking on now takes ~30 seconds vs ~7 seconds on main.