Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jan 16, 2026

Switches our pre-commit checker from pre-commit to prek, because prek is way faster and less socially complicated than pre-commit (e.g., pre-commit/pre-commit.com#687 (comment)). See this comment the apache airflow project detailing why they switched.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jan 16, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing d-v-b:chore/use-prek (620dc06) with main (68359bc)

Summary

✅ 30 untouched benchmarks

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jan 20, 2026
@d-v-b d-v-b requested a review from maxrjones January 20, 2026 09:39
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is it worth renaming the readme badge?

@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 21, 2026

I think the readme badge indicates whether we are passing according to pre-commit CI, which is still applicable since both prek and pre-commit use the same .pre-commit configuration?

@maxrjones
Copy link
Member

I think the readme badge indicates whether we are passing according to pre-commit CI, which is still applicable since both prek and pre-commit use the same .pre-commit configuration?

makes sense, thanks for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants