-
-
Notifications
You must be signed in to change notification settings - Fork 377
chore/use prek #3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore/use prek #3658
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
maxrjones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Is it worth renaming the readme badge?
|
I think the readme badge indicates whether we are passing according to pre-commit CI, which is still applicable since both prek and pre-commit use the same .pre-commit configuration? |
makes sense, thanks for the explanation |
Switches our pre-commit checker from
pre-committoprek, becauseprekis way faster and less socially complicated than pre-commit (e.g., pre-commit/pre-commit.com#687 (comment)). See this comment the apache airflow project detailing why they switched.