Improve error message when the graph contains cyclic dependencies#33
Open
JeremyIV wants to merge 2 commits intoyahoo:masterfrom
Open
Improve error message when the graph contains cyclic dependencies#33JeremyIV wants to merge 2 commits intoyahoo:masterfrom
JeremyIV wants to merge 2 commits intoyahoo:masterfrom
Conversation
|
Great! I would raise the same exception type `networkx.exception.NetworkXUnfeasible. |
Author
|
Ok, made the change. It throws the same NetworkXUnfeasible exception now. |
|
Just to be lcear, have no saying i this project. |
Author
|
Ah... Is this project maintained anymore? Are there better maintained alternatives? |
|
I submitted a lot of fixes and enhancements in #22 (and other issues) a couple of years ago, that were not addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a more helpful exception when trying to compose a graph with cyclic dependencies.
Example message: (helpful part at the bottom)
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.