build riscv64 wheel#387
Conversation
Co-authored by: nijincheng@iscas.ac.cn;
for more information, see https://pre-commit.ci
Co-authored by: nijincheng@iscas.ac.cn;
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building riscv64 wheels for python-xmlsec. PyPI has recently added support for riscv64 wheel packages, and this change enables the project to build and distribute wheels for this architecture.
- Adds riscv64 to the list of supported architectures in the cibuildwheel configuration
- Implements a workaround for an OpenSSL assembly code issue on riscv64 by adding the
no-asmflag - Updates dependency versions (cibuildwheel, ruff, setuptools, lxml) to support the new build requirements
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Adds riscv64-specific OpenSSL build configuration with no-asm flag to work around assembly code relocation issues; moves import statement |
| pyproject.toml | Adds riscv64 to supported Linux architectures, pins setuptools and lxml versions, skips musllinux_riscv64 builds, adds setuptools_scm configuration |
| .github/workflows/wheels.yml | Updates cibuildwheel version from 2.21.3 to 3.1.4 |
| requirements-test.txt | Updates ruff version from 0.12.3 to 0.13.0 |
| doc/source/requirements.txt | Pins lxml version to 6.0.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The CI failure is a network issue; just retry it. This problem might occur a bit frequently here. Perhaps we could consider putting these required dependencies in a separate repository and pulling from that repository when needed. This way we can avoid network issues caused by accessing other websites. |
You're right, the failure is because of a network issue. I'm planning to fix the dependencies to a specific version and put them all in a separate repository as we did for Windows builds before releasing the next version. |
Co-authored by: nijincheng@iscas.ac.cn;
Co-authored by: nijincheng@iscas.ac.cn;
|
Hello maintainer @mxamin , could you please consider releasing a new version to provide available rv64 wheels on PyPI? |
|
@ffgan Sure! I was planning to do that soon. Probably next week, or maybe earlier if I find some spare time. |
2 participants
PyPI recently added support for riscv64(rv64) wheel packages, so we can consider adding rv64 support for python-xmlsec.
Below are the CI results:
Wheel build
The results are generally well presented.
Other Info
Co-authored by: nijincheng@iscas.ac.cn;