Reset key and iv prior to aes decryption in crypto demo#288
Draft
AlexLanzano wants to merge 1 commit intowolfSSL:mainfrom
Draft
Reset key and iv prior to aes decryption in crypto demo#288AlexLanzano wants to merge 1 commit intowolfSSL:mainfrom
AlexLanzano wants to merge 1 commit intowolfSSL:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the AES CBC demo where decryption produces incorrect results when using client-side crypto (device ID -2) rather than HSM server callbacks. The issue occurs because CBC mode requires different key schedules for encryption vs decryption, and the previous code only reset the IV without resetting the key schedule.
Changes:
- Updated
wh_DemoClient_CryptoAesCbcto callwc_AesSetKeywithAES_DECRYPTIONflag instead ofwc_AesSetIVbefore decryption - Updated the comment and error message to accurately reflect the change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #287
Fix AES CBC decryption in the crypto demo by using wc_AesSetKey instead of wc_AesSetIV to properly reset both the key schedule for decryption and the IV before decryptin