Restore previous tenant and tenant callback#10
Open
pupeno wants to merge 4 commits intowireframe:masterfrom
Open
Restore previous tenant and tenant callback#10pupeno wants to merge 4 commits intowireframe:masterfrom
pupeno wants to merge 4 commits intowireframe:masterfrom
Conversation
… (a callback). This is useful when there's some extra settings to be done, like setting the global locale to match that of the tenant.
This unfortunately forces the name of the callback to be fixed. If necessary, it can be a global configuration, but at this point it seems to add more trouble than it's worth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request I'm including a feature which I sent in a previous one that I closed:
as well as a new feature: when entering the scope of a tenant, call a method in the object.
Everything includes tests. The previous feature has been in production for months and the second one will be in production soon.