[Maintenance] Bump plugin to Sylius 2.0#77
Merged
lruozzi9 merged 12 commits intowebgriffe:masterfrom Nov 17, 2025
Merged
Conversation
lruozzi9
requested review from
LucaGallinari,
Copilot,
lamasfoker,
lruozzi9 and
mmenozzi
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the plugin from Sylius 1.x to Sylius 2.0, introducing LiveComponents architecture and updating dependency versions.
Key changes include:
- Upgraded PHP requirement from 8.0 to 8.2 and Symfony from 5.4+ to 6.4+/7.3+
- Replaced custom JavaScript with Symfony UX LiveComponent for form handling
- Introduced factory and processor patterns for subscription creation
- Migrated from SyliusUi events to Twig Hooks for template rendering
Reviewed Changes
Copilot reviewed 148 out of 171 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP, Symfony, and Sylius version constraints; removed psalm dependency |
| config/services.yaml | Updated service definitions to remove deprecated availability checker references and add new processor/component services |
| src/Twig/Component/AddNotificationComponent.php | New LiveComponent replacing JavaScript-based form handling |
| src/Factory/SubscriptionFactory.php | New factory implementing subscription creation logic extracted from controller |
| src/Processor/SubscriptionProcessor.php | New processor centralizing subscription business logic |
| src/Controller/SubscriptionController.php | Simplified by removing subscription creation logic moved to processor |
| templates/shop/product/show/content/info/summary/add_notification.html.twig | New template using LiveComponent architecture |
| config/twig_hooks/** | New Twig Hooks configuration replacing deprecated SyliusUi events |
| tests/Application/** | Removed old test application files in favor of sylius/test-application package |
| behat.yml.dist | Updated paths to use sylius/test-application |
Comments suppressed due to low confidence (1)
src/Twig/Component/AddNotificationComponent.php:1
- Extra space and asterisk in PHPDoc comment. Should be
/** @var ProductVariantInterface|null $variant */
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wojdylak
force-pushed
the
upgrade-2-0
branch
5 times, most recently
from
59dfccb to
3aac1ed
Compare
Member
|
Looks good, thank you @Wojdylak! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #76