Skip to content

Conversation

@MrOrange9-JCT
Copy link

@MrOrange9-JCT MrOrange9-JCT commented Sep 28, 2024

I figured out that the ED2K indexer just searches for the query, so it is indeed only searching for the show's name.
I edited the kotlin code but I have absolutely no idea of what should I do next, I have never used Kotlin, Java or Docker before, so I'm as lost as I could be.

Also I know this is a quite hard-coded solution, here has to be some more work done.

@danielchc
Copy link

danielchc commented Jan 2, 2025

I fixed that and a few things on my fork https://github.com/danielchc/amarr

@Mika3578
Copy link

Mika3578 commented Feb 2, 2026

I fixed that and a few things on my fork https://github.com/danielchc/amarr

Hi @danielchc,

I saw your comment on vexdev/amarr#94 saying you fixed the episode/TV search behavior in your fork: https://github.com/danielchc/amarr.

Would you be willing to open a PR to vexdev/amarr with your fixes (or a clean, minimal subset of them)? That would really help the community because #94 has been open for a while and the current TV search often misses results depending on the naming format and special characters.

  • Query cleanup / special characters: normalize titles (remove accents/diacritics) and strip punctuation before searching, so titles like "C’est un complot" / accents / apostrophes don’t break search.
  • TV episode search formats: add/keep additional episode patterns (e.g. S03E05, 3x05, and 305) to improve matching across different release naming styles.

If it helps, you could cherry-pick the focused commits that implement the key behavior and avoid larger unrelated changes, then open a PR from a branch based on vexdev:main.

Thanks in advance — a PR from your fork would likely get #94 unstuck and improve results for a lot of users.

@danielchc
Copy link

Hi @Mika3578 !

Unfortunately, right now my fork is broken, I have changed a lot of things, so adapting what I currently have into a clean a PR would take me some time. I’d need to re-clone the upstream repository and carefully reapply the changes

To give some context on what I changed in my fork:

  • I added caching to search results so repeated searches (you can use to Automatic Search without timeout) don’t take as long.
  • I improved filtering by normalizing titles (removing accents/diacritics and punctuation).
  • I expanded TV episode matching to support multiple common formats (e.g. S03E05, 3x05, 305) to better handle different release naming styles.

At the moment I don’t really have the time to properly cherry-pick, clean up, and submit those changes as a PR in the way the project deserves. That said, it’s definitely something I’d like to do in the future.

In the meantime, anyone is welcome to use my fork directly — it provides the same improved behavior. I also publish a Docker image on Docker Hub, so it should be easy to try without building locally.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants