Hstar calculation move to confinement time functions.#4050
Hstar calculation move to confinement time functions.#4050
Conversation
ajpearcey
added
Confinement time
process/physics.py
Outdated
| if physics_variables.i_rad_loss == 1: | ||
| physics_variables.hstar = hfact * ( p_plasma_loss_mw / ( p_plasma_loss_mw | ||
| + physics_variables.pden_plasma_sync_mw | ||
| + physics_variables.p_plasma_inner_rad_mw ) ) ** 0.31 |
There was a problem hiding this comment.
Why are variables of different units being added. There should be a variable for total synchrotron radiation power
There was a problem hiding this comment.
didn't notice that before, looks like the synchrotron had been missing from the calculation for a while.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4050 +/- ##
==========================================
+ Coverage 46.86% 46.87% +0.01%
==========================================
Files 136 136
Lines 29228 29232 +4
==========================================
+ Hits 13698 13703 +5
+ Misses 15530 15529 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajpearcey
force-pushed
the
issue-3534-hstar-calc
branch
from
34e66be to
6a17655
Compare
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
The quality jobs are failing
| """H factor on energy confinement times, radiation corrected (`iteration variable 10`).""" | ||
|
|
||
|
|
||
| hstar : float = None |
There was a problem hiding this comment.
Maybe @chris-ashe can comment but is this variable in keeping with the style guide for variable names?
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Happy with changes but conflict needs resolving
ajpearcey
force-pushed
the
issue-3534-hstar-calc
branch
from
5daa558 to
7f8b16a
Compare
4 participants
Description
Closes #3534. I have moved Hstar calculation out of
outplas(). I propose keeping the assumption that Hstar is computed with the IPB-98y2 scaling, as the way we currently calculated the energy confinement scaling means while possible there isn't an elegant solution.Checklist
I confirm that I have completed the following checks: