Add instant command execution with modifier keys#279
Draft
Conversation
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add instant command functionality for text selection
Add instant command execution with modifier keys
Feb 8, 2026
ujiro99
reviewed
Feb 11, 2026
| // Check if modifier key is pressed | ||
| if (!checkModifierKey(event)) return | ||
|
|
||
| // Check if there's selected text |
Owner
There was a problem hiding this comment.
selectedTextはuseSekectContextに入っているので、それを持ってくること
Contributor
Author
There was a problem hiding this comment.
修正しました。window.getSelection() の代わりに useSelectContext から selectionText を使用するようにしました。
コミット: b3dab25
変更内容:
selectionTextを context から直接使用- 不要な
positionElmパラメータを削除 - より一貫したアーキテクチャに
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instant Command Feature Implementation
インスタントコマンド機能の実装が完了しました!✅
Implementation Checklist
1. Type Definitions - Update types/index.ts
2. Default Settings - Update services/option/defaultSettings.ts
3. Schema Validation - Update types/schema.ts
4. Detection Hook - Create hooks/useDetectInstantCommand.ts
5. Integration - Update App.tsx
6. Options UI - Update components/option/SettingForm.tsx
7. Internationalization - Update locale files
8. Build Verification
9. Testing
10. Code Review
Summary
インスタントコマンド機能が正常に実装されました。この機能により、ユーザーはモディファイアキー(Shift、Ctrl、Alt)を押しながらテキストを選択することで、メニューを表示せずに選択したコマンドを即座に実行できます。
Latest Changes (PR Feedback):
selectionTextfromuseSelectContextinstead ofwindow.getSelection()positionElmparameterOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.