PM-3532 Update redux on open to work step #1460
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| try { | ||
| await Promise.all([ | ||
| const [, updatedTraits] = await Promise.all([ |
There was a problem hiding this comment.
[💡 readability]
The use of array destructuring with const [, updatedTraits] can be confusing. Consider naming the first element explicitly if it's not needed, or use a more descriptive variable name for updatedTraits to clarify its purpose.
| ]) | ||
|
|
||
| const personalizationTrait = updatedTraits?.find( | ||
| (t: any) => t.traitId === UserTraitIds.personalization, |
There was a problem hiding this comment.
[maintainability]
The type any is used for t in the find method. Consider defining a specific type for t to enhance type safety and code clarity.
| availability, | ||
| preferredRoles, | ||
| }, | ||
| openToWork: openToWork |
There was a problem hiding this comment.
[correctness]
The use of _.omitBy with _.isUndefined is a good approach to remove undefined values, but ensure that openToWork is always an object or undefined. If openToWork can be null or another falsy value, this could lead to unexpected behavior.
2 participants
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-3688
What's in this PR?