Fluent Builder Implementation #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 29, 2026 17:53
toastwaffle
requested changes
Jan 30, 2026
Contributor
toastwaffle
left a comment
toastwaffle
left a comment
There was a problem hiding this comment.
Please golangci-lint fmt ./...
| for _, k := range keys { | ||
| rk, err := newReflectKey(k) | ||
| if err != nil { | ||
| panic(fmt.Errorf("invalid key passed to Provides: %w", err)) |
Contributor
There was a problem hiding this comment.
I'm not ok with this panicking. At a minimum it should use the Must helper, but I think it would be better to capture the errors, store them in the builder struct as a slice, and have the Build function return the errors (and then optionally provide a Tasks method which calls Must(Build()) like we do for ReflectMulti)
Contributor
|
Superseded by #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Fluent Builder pattern