Simplify parallel GPIO interface and add new error variant#13
Closed
andresovela wants to merge 2 commits intotherealprof:masterfrom
andresovela:master
Closed
Simplify parallel GPIO interface and add new error variant#13andresovela wants to merge 2 commits intotherealprof:masterfrom andresovela:master
andresovela wants to merge 2 commits intotherealprof:masterfrom
andresovela:master
Conversation
therealprof
requested changes
Feb 13, 2021
Owner
therealprof
left a comment
There was a problem hiding this comment.
Thanks for the PR, it certainly looks interesting and I'll have a play with the DBUS to check how it plays with applications.
I'd like to ask you to split these two changes out into separate PRs:
- The addition of the RSError
- The change of BusWriteError -> DCError
Also please add changes to the CHANGELOG.md.
Splitting off the drivers by bumping their version seems like a good idea but I probably need to invest some time (or wait for PRs) to do it properly by having them use their own CHANGELOG.md, etc. Maybe even get rid of the workspace approach since it's still a major PITA to work with -- I totally anticipated that this would have been figured out and improved by now. 🤷🏻♂️
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simplified the API for the parallel GPIO interface by grouping the bus into an array of pins rather than 8 individual pins. This allows to further simplify the
set_value()function.I also added a new variant to the
DisplayErrorenum to represent issues that arise while asserting or de-asserting the reset pin. That is not used in these crates, but it is a useful error to have for consumers of this library.