Conversation
vkarpov15
approved these changes
Apr 14, 2022
bergundy
reviewed
Apr 14, 2022
| COPY ["package.json", "./"] | ||
| RUN npm install --production | ||
|
|
||
| ARG TEMPORAL_SERVER="host.docker.internal:7233" |
Member
There was a problem hiding this comment.
Why put these in args?
It's typically something you'd provide at container run time, not bake into the image since this image could be used in different environments.
bergundy
requested changes
Apr 14, 2022
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Not loving this sample.
It's not a complete production sample because it omits logging / metrics setup and has a lot of duplication with the mtls sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding instrumentation and more README updates in next PR. And then automated cloud test.