-
-
Notifications
You must be signed in to change notification settings - Fork 144
feat(router): add signature validation middleware and route attribute #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tresor-Kasenda
wants to merge
6
commits into
tempestphp:3.x
Choose a base branch
from
Tresor-Kasenda:feature/valid-signature-middleware
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(router): add signature validation middleware and route attribute #1946
Tresor-Kasenda
wants to merge
6
commits into
tempestphp:3.x
from
Tresor-Kasenda:feature/valid-signature-middleware
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L validation
Add a route decorator attribute that automatically validates signed URLs,
eliminating the need for manual validation in each controller method.
Features:
- New #[ValidSignature] attribute to enforce signature validation on routes
- Returns 403 Forbidden when signature is missing, invalid, or expired
- Works with both permanent and temporary signed URLs
Usage:
#[Get('/verify-email/{token}')]
#[ValidSignature]
public function verifyEmail(string $token): Response
{
// This code only executes if the signature is valid
}
Files added:
- packages/router/src/ValidSignature.php - Route decorator attribute
- packages/router/src/ValidSignatureMiddleware.php - Validation middleware
- tests/Integration/Route/ValidSignatureMiddlewareTest.php - 8 integration tests
- tests/Integration/Route/Fixtures/SignedUrlController.php - Test fixture
innocenzi
requested changes
Feb 6, 2026
Member
innocenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call the middleware ValidateSignatureMiddleware.
I think we also need a convention for the route attributes, cc @brendt.
#[ValidSignature] attribute for automatic signed URL validation…ery] for route-specific application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a route decorator attribute that automatically validates signed URLs, eliminating the need for manual validation in each controller method.
Motivation
Currently, when using signed URLs, developers must manually validate the signature in every controller method:
This is repetitive, error-prone, and clutters controller code with validation logic.
Solution
The new
#[ValidSignature]attribute handles validation automatically:Features
Forbiddenwhen:signed_uri()andtemporary_signed_uri()Usage Examples
Permanent signed URL
Temporary signed URL