Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8382b81 to
443fb6f
Compare
4ef860e to
c4efc17
Compare
|
Example for pipeline-controller, On cluster-bot cluster default tls profile is Intermediate |
|
@anithapriyanatarajan @mbpavan @enarha |
|
Few high level notes on the implementation without getting down to the code level: [EDIT] I suggest we meet and discuss both approaches instead of going back and forth on both PRs. Once we agree on a path forward, we can proceed with just one PR. |
|
@enarha the context is not immutable, ieach time we do context.WithValue, returns new context. I will go ahead, close my PR, I will comment your PR on what needs to be reworked/refined |
Changes
Details:
Coauthored with Claude
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes