Conversation
Replace direct JWT token in redirect URL with a single-use auth code pattern. The LinkedIn callback now generates a temporary code stored in MongoDB (60s TTL), and the frontend exchanges it via POST /api/auth/exchange for a JWT token. This prevents token exposure in browser history and URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthCodeMongoDB model with 60-second TTL auto expiryPOST /api/auth/exchangeendpoint to exchange auth code for JWT tokenChanges
src/models/auth_code_model.ts(new): AuthCode schema with unique index and 60s TTLsrc/controllers/auth_controller.ts: LinkedIn callback now generates a temp auth code instead of returning JWT in redirect; addedexchangeAuthCodecontrollersrc/routes/auth_routes.ts: RegisterPOST /exchangerouteTesting done
All tests performed manually against local dev server (
npm run dev):POST /api/auth/exchangewith empty body returns{"error": "Auth code is required"}POST /api/auth/exchangewith{"code": "fakecode123"}returns{"error": "Invalid or expired auth code"}GET /api/auth/linkedin, confirmed redirect URL contains onlycodeparam (no token/userId), exchanged the code viaPOST /api/auth/exchangeand received{"message": "Authentication successful", "userId": "...", "token": "..."}{"error": "Invalid or expired auth code"}(confirmed atomic delete on first use)npm run buildpasses with no TypeScript errors