Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors BridgeJS closure-related JS glue generation to reuse the shared lift/lower thunk builders, aiming to unify how Swift closures and JS callbacks are bridged.
Changes:
- Replaced bespoke closure parameter/return lift/lower code with
ImportedThunkBuilder/ExportedThunkBuilder-based generation. - Added
hasDirectAccessToSwiftClasstoIntrinsicJSFragment.PrintCodeContextto control whether generated JS can reference Swift heap object classes directly vs via_exports[...]. - Updated BridgeJSLink test snapshots for closure bridging (
SwiftClosure*.js) to match the new generation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Plugins/BridgeJS/Tests/BridgeJSToolTests/Snapshots/BridgeJSLinkTests/SwiftClosureImports.js | Snapshot update for closure import glue output. |
| Plugins/BridgeJS/Tests/BridgeJSToolTests/Snapshots/BridgeJSLinkTests/SwiftClosure.js | Snapshot update for closure glue output; exposes an optional Swift heap object construction scoping issue. |
| Plugins/BridgeJS/Sources/BridgeJSLink/JSGlueGen.swift | Introduces hasDirectAccessToSwiftClass and uses it when emitting Swift heap object construction in lift fragments. |
| Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift | Refactors closure invoke/lower generation to use shared thunk builders; adjusts thunk builder function rendering API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js
Outdated
Show resolved
Hide resolved
Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js
Show resolved
Hide resolved
Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js
Show resolved
Hide resolved
7311617 to
f90d918
Compare
krodak
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactoring to unlock #598
Changes
We had been having closure-specific lift/lower logic for JS glue codegen:
closureLiftParameterclosureLowerReturnclosureLowerParameterclosureLiftReturnHowever, they are essentially the same as the regular lift/lower logic, so we should uniformly use them to reduce the cost of adding a new type support.