Add SPKI-based certificate pinning support#883
Open
o-nnerb wants to merge 12 commits intoswift-server:mainfrom
Open
Add SPKI-based certificate pinning support#883o-nnerb wants to merge 12 commits intoswift-server:mainfrom
o-nnerb wants to merge 12 commits intoswift-server:mainfrom
Conversation
Contributor
Author
|
Good morning, @Lukasa. Does this PR make sense for AsyncHTTPClient? I’m currently developing an application and need this feature. I’ve researched the topic and found some use cases on https://github.com/datatheorem/TrustKit. I’ve also made this a draft because I’ll need more time to implement the tests. |
Lukasa
reviewed
Feb 3, 2026
Sources/AsyncHTTPClient/ConnectionPool/HTTPConnectionPool+Factory.swift
Outdated
Show resolved
Hide resolved
Sources/AsyncHTTPClient/ConnectionPool/HTTPConnectionPool+Factory.swift
Outdated
Show resolved
Hide resolved
Sources/AsyncHTTPClient/ConnectionPool/ChannelHandler/SPKIPinningHandler.swift
Outdated
Show resolved
Hide resolved
Sources/AsyncHTTPClient/ConnectionPool/ChannelHandler/SPKIPinningHandler.swift
Outdated
Show resolved
Hide resolved
Sources/AsyncHTTPClient/ConnectionPool/ChannelHandler/SPKIPinningHandler.swift
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces SPKI-based certificate pinning to
AsyncHTTPClient, enabling clients to enforce explicit trust in server certificates beyond standard PKI validation. This provides protection against compromised Certificate Authorities and MITM attacks.🔑 Key features
.strict(production): blocks connections on pin mismatch.audit(staging): allows connections but logs warnings🛡️ Security by design
.strictmode🧪 Usage example
openssl dgst -sha256 -binary | base64 -A)📚 References