Add testProxyStreamingNoDeadlock test#181
Open
PopFlamingo wants to merge 2 commits intoswift-server:mainfrom
PopFlamingo:fix-self-stream-deadlock
Open
Add testProxyStreamingNoDeadlock test#181PopFlamingo wants to merge 2 commits intoswift-server:mainfrom PopFlamingo:fix-self-stream-deadlock
PopFlamingo wants to merge 2 commits intoswift-server:mainfrom
PopFlamingo:fix-self-stream-deadlock
Conversation
Because of there is a maximum number of concurrent connections per host it is possible for the client to deadlock itself when making requests with a streamed body if the body data is itself requested from the same host. If we reach the maximum number of concurrent requests for a certain host, and if all active tasks use a streamed body that obtains its data from requests to the same host, then the bodies will never be obtained as the requests they need to make will be put on a queue whose ability to dequeue them depends on their very result -> deadlock.
Contributor
|
Just as a heads up, the main development branch has been changed to This PR has been re-targeted to main and should just work. However when performing rebases etc please keep this in mind -- you may want to fetch the main branch and rebase onto the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because there is a maximum number of concurrent connections per host
it is possible for the client to deadlock itself when making requests
with a streamed body if the body data is itself requested from the same
host.
If we reach the maximum number of concurrent requests for a certain
host, and if all active tasks use a streamed body that obtains its data
from requests to the same host, then the bodies will never be obtained as
the requests they need to make will be put on a queue whose ability to
dequeue them depends on their very result -> deadlock.