Merged
Conversation
[SPT-1480] RDDM Accessibility optimizations
# Conflicts: # Brewfile.lock.json # Example/ReactiveDataDisplayManager/Collection/CollectionCompositionalViewController/CollectionCompositionalViewController.swift # Example/ReactiveDataDisplayManager/Collection/CollectionViewController/CollectionViewController.swift # Example/ReactiveDataDisplayManager/Collection/MainCollectionViewController/MainCollectionViewController.swift # Example/ReactiveDataDisplayManager/Table/MainTableViewController/MainTableViewController.swift # Example/ReactiveDataDisplayManager/Table/SectionTitleTableViewController/SectionTitleTableViewController.swift # Example/ReactiveDataDisplayManager/Table/Views/Cells/ExpandableTableCell/ExpandableTableCell.swift # Example/ReactiveDataDisplayManager/Table/Views/Cells/TitleTableViewCell/TitleTableViewCell.swift # Example/project.yml # Example/targets/template.yml # Gemfile.lock # ReactiveDataDisplayManager.podspec # ReactiveDataDisplayManagerTests/BaseStackDataDisplatManagerTests.swift # ReactiveDataDisplayManagerTests/Mocks/AutoMockable.generated.swift # Source/Collection/Deprecated/BaseCollectionDataDisplayManager.swift # Source/Collection/Generators/EmptyCollectionFooterGenarator.swift # Source/Collection/Generators/EmptyCollectionHeaderGenerator.swift # Source/Collection/Manager/BaseCollectionManager.swift # Source/Collection/Plugins/PluginAction/CollectionPaginatablePlugin.swift # Source/Collection/Protocols/CollectionFoldableItem.swift # Source/Protocols/GeneratorsProvider.swift # Source/Protocols/Protocols.swift # Source/Table/DataSource/TableGeneratorsProvider.swift # Source/Table/Deprecated/BaseTableDataDisplayManager.swift # Source/Table/Generators/EmptyHeaderGenerator.swift # Source/Table/Manager/BaseTableManager.swift # Source/Table/Manager/GravityTableManager.swift # Source/Table/Manager/ManualTableManager.swift # Source/Table/Plugins/PluginAction/TableDisplayablePlugin.swift # Source/Table/Plugins/PluginAction/TableLastCellIsVisiblePlugin.swift # Source/Table/Plugins/PluginAction/TablePaginatablePlugin.swift # hooks/post-checkout # project.yml
SwiftLint found issues
Generated by 🚫 Danger Swift against 7fd0ec7 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
+ Coverage 71.37% 72.66% +1.28%
===========================================
Files 146 161 +15
Lines 4457 4905 +448
Branches 2000 2224 +224
===========================================
+ Hits 3181 3564 +383
- Misses 1176 1221 +45
- Partials 100 120 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Итого возьмем на заметку что мердж прошел успешно за исключением a11y теста стеков и компонентов. На CI успех потому что пока проверяем на Xcode 14. Разработка и отладка стековой ячейки в процессе - #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Что сделано?
Зачем это сделано?
Чтобы объединить изменения из готовящейся 8.0 и зарелиженой. 7.4
На что обратить внимание?
Как протестировать?
П.C. Полезно будет также прогнать тесты на Xcode 15, чтобы зафиксировать работу "performAccessibilityAudit"