feat: context-sensitive perm tags creation#1822
Open
chittolinag wants to merge 3 commits intomainfrom
Open
Conversation
chittolinag
commented
Jan 23, 2026
Comment on lines
+1
to
+53
| const INLINE_PARENT_NAMES = new Set([ | ||
| 'w:r', | ||
| 'w:hyperlink', | ||
| 'w:smartTag', | ||
| 'w:fldSimple', | ||
| 'w:proofErr', | ||
| 'w:del', | ||
| 'w:ins', | ||
| 'w:p', // Paragraph is an inline container; unknown children must be inline-safe | ||
| ]); | ||
|
|
||
| const INLINE_NODE_NAMES = new Set([ | ||
| 'm:oMathPara', | ||
| 'm:oMath', | ||
| 'm:t', | ||
| 'm:r', | ||
| 'm:ctrlPr', | ||
| 'm:sSupPr', | ||
| 'm:e', | ||
| 'm:sup', | ||
| 'm:sSup', | ||
| ]); | ||
|
|
||
| const BLOCK_BOUNDARY_NAMES = new Set(['w:body', 'w:tbl', 'w:tc', 'w:tr']); | ||
|
|
||
| /** | ||
| * Determines if the current DOCX node position accepts inline-only content. | ||
| * Walks up the ancestor chain until it finds an inline parent or block boundary. | ||
| * | ||
| * @param {Array<{ name?: string }>} [path=[]] Ancestor chain leading to the current node. | ||
| * @param {string} [currentNodeName] Optional immediate node name override. | ||
| * @returns {boolean} | ||
| */ | ||
| export const isInlineContext = (path = [], currentNodeName) => { | ||
| const immediateName = currentNodeName ?? path[path.length - 1]?.name; | ||
| if (immediateName && INLINE_NODE_NAMES.has(immediateName)) { | ||
| return true; | ||
| } | ||
| if (!Array.isArray(path) || path.length === 0) return false; | ||
|
|
||
| for (let i = path.length - 1; i >= 0; i--) { | ||
| const ancestorName = path[i]?.name; | ||
| if (!ancestorName) continue; | ||
| if (INLINE_NODE_NAMES.has(ancestorName) || INLINE_PARENT_NAMES.has(ancestorName)) { | ||
| return true; | ||
| } | ||
| if (BLOCK_BOUNDARY_NAMES.has(ancestorName)) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Just moved this out of passthroughNodeImporter so it can be reused.
Contributor
Via L3 deep analysis · critical risk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a context-aware creation of
permStartandpermEndtags. We're reusing the same logic that we use in thepassthroughNodeImporterfile, which detects the context based on the node's path.If the context accepts only
block, we'll create a block permission tag. Otherwise we'll create the inline version.