Guid: optimize comparison functions#18
Merged
ritchiecarroll merged 9 commits intosttp:mainfrom Mar 31, 2025
Merged
Conversation
added 9 commits
January 10, 2025 17:22
Instead of looping over each byte and checking, bytes.Equal uses string conversion and equality testing, which should use compiler intrinsics.
This just... works. And is slightly faster than unsafe conversion, too.
fef6ccd to
8fa6ed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
guid.Equal() is slow. We call it in a hot loop, and it shows up as a significant part of the profile for one component.
Added benchmarking, and tested a few different approaches. Was reminded by a coworker that
==is valid for arrays in Go, and the compiler does a great job:The current approach has two problems:
a == bworks just fine for Guids and is ~35x faster.a == bapproach, it adds 0.6ns - from 0.2 to 0.8ns.Fixing both improves overall throughput from 8ns/op to 0.2ns/op, a ~40x improvement.
I fixed both APIs rather than remove one just so there's no breakage and it's easier to get reviewed.