Make CompactMeasurements more useful for DataPublishers#15
Open
pixelherodev wants to merge 4 commits intosttp:mainfrom
Open
Make CompactMeasurements more useful for DataPublishers#15pixelherodev wants to merge 4 commits intosttp:mainfrom
pixelherodev wants to merge 4 commits intosttp:mainfrom
Conversation
Member
|
How often do you use the compact measurement implementation internally? I had suspected this would be rare as people would generally opt for TSSC mode deployments? |
Contributor
Author
... exclusively. This is the only mode that our data publisher currently supports. This wasn't a deliberate choice; someone started working on the data publisher a few years ago and then it got dropped; I just finished it and expanded it, I didn't question their decision of which mode to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the representation of compactmeasurements lighter, and drops exposed APIs that are only needed internally. It also implements a method for encoding CompactMeasurements into byte buffers for sending across the network.
I tested this with a DataPublisher for PingThings, works well and fast :)