Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR removes several custom
SizeOfinstances. The default instances provided by Lean interact much better with the built‑in termination checker, and the custom ones were interfering with automation.Previously, a custom
SizeOf Stringinstance had been introduced to avoid non‑computability issues with the default instance. That workaround is not needed: the definition that depended on it now callsString.lengthdirectly, so the custom instance (which can break downstream code) is commented out.Note: Many uses of
@SizeOf.sizeOf αin the codebase are not guarded by an explicit[SizeOf α]argument, which causes Lean to fall back to the default instance and return0unexpectedly. Adding the missing type‑class arguments exposes further issues, since some types lack computableSizeOfinstances. Long‑term, it may be cleaner to introduce a dedicated type-class and migrate the relevant code to use it consistently, rather than relying on Lean's automatically generatedSizeOfinstances.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.