fix: emit ToolUseStreamEvent on contentBlockStart for thinking-phase tool calls#1569
Open
a-sekka wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: emit ToolUseStreamEvent on contentBlockStart for thinking-phase tool calls#1569a-sekka wants to merge 1 commit intostrands-agents:mainfrom
a-sekka wants to merge 1 commit intostrands-agents:mainfrom
Conversation
…tool calls When models with extended thinking execute tool calls during the reasoning phase, the tool use was never displayed to users because ToolUseStreamEvent was only emitted during contentBlockDelta events. Now emit a ToolUseStreamEvent immediately when contentBlockStart contains toolUse data, ensuring all tool executions are visible via the callback handler. Closes strands-agents#1551
a-sekka
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolUseStreamEventwas only emitted duringcontentBlockDelta, notcontentBlockStartToolUseStreamEventimmediately whencontentBlockStartcontainstoolUsedata, soPrintingCallbackHandlerdisplays "Tool #N: name" for all tool executionsTest plan
test_process_streamto account for new eventtest_process_stream_emits_tool_use_event_on_content_block_startverifying the fixCloses #1551