Skip to content

feat: adding terminate attribute for after-model-call-event hooks#1549

Open
gaurav71531 wants to merge 2 commits intostrands-agents:mainfrom
gaurav71531:experiment-hooks
Open

feat: adding terminate attribute for after-model-call-event hooks#1549
gaurav71531 wants to merge 2 commits intostrands-agents:mainfrom
gaurav71531:experiment-hooks

Conversation

@gaurav71531
Copy link

@gaurav71531 gaurav71531 commented Jan 23, 2026

Description

Supporting agent event loop termination via after-model-call-event hooks

Type of Change

Bug fix
[x] New feature
Breaking change
Documentation update
Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mehtarac
Copy link
Member

mehtarac commented Feb 3, 2026

/strands review

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@poshinchen poshinchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there's conflict, could you resolve it?

@github-actions github-actions bot added size/xl and removed size/m labels Feb 4, 2026
@pgrayy
Copy link
Member

pgrayy commented Feb 5, 2026

Per discussion, we want to instead try to expand the concept of interrupt to be used in cases like this where the user stops the agent loop from a hook lifecycle event. The new behaviors to support are:

  • Stop agent loop without the expectation of resuming.
    • Currently, interrupts stop the agent loop and have a user provide a response. That response is carried back to where the interrupt occurred without taking another turn in the agent loop.
  • Set AgentResult stop reason to "interrupt".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants