Update STM32RTC to align with the integration of ArduinoCore-API #122
+43
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Aymane-ST
force-pushed
the
dev
branch
2 times, most recently
from
14a8b10 to
f99d598
Compare
fpistm
requested changes
Jan 28, 2026
| } | ||
| #if defined(LED_BUILTIN) | ||
| digitalWrite(pin, toggling); | ||
| digitalWrite(pin, (PinStatus)toggling); |
Member
There was a problem hiding this comment.
Maybe better to avoid cast. change type of the variable and update also the line when it change.
toggling = (toggling == LOW) ? HIGH: LOW;
| #endif | ||
|
|
||
| static uint8_t conv2d(const char* p) { | ||
| uint8_t conv2d(const char* p) { |
Member
There was a problem hiding this comment.
Any reason to change it to static ?
| @@ -0,0 +1,31 @@ | |||
| # v3.21 implemented semantic changes regarding $<TARGET_OBJECTS:...> | |||
Member
There was a problem hiding this comment.
Create a dedicated commit: chore: add cmake support or someting like that.
github-project-automation
bot
moved this from In progress
to Needs review
in STM32 core based on ST HAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: stm32duino/Arduino_Core_STM32/#2852