Fix #2392: EmbeddingProvider and RerankingProvider decideRetry() buggy#2393
Merged
tatu-at-datastax merged 8 commits intomainfrom Feb 13, 2026
Merged
Fix #2392: EmbeddingProvider and RerankingProvider decideRetry() buggy#2393tatu-at-datastax merged 8 commits intomainfrom
EmbeddingProvider and RerankingProvider decideRetry() buggy#2393tatu-at-datastax merged 8 commits intomainfrom
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
| // Get the whole response body | ||
| JsonNode rootNode = jakartaResponse.readEntity(JsonNode.class); | ||
| return rootNode.toString(); | ||
| return jakartaResponse.readEntity(String.class); |
Contributor
Author
There was a problem hiding this comment.
Avoid parsing JSON, then re-generating
| && se.code.equals(RerankingProviderException.Code.RERANKING_PROVIDER_TIMEOUT.name())); | ||
|
|
||
| boolean retry = | ||
| throwable instanceof RerankingProviderException rpe |
Contributor
Author
There was a problem hiding this comment.
note: remove getCause() as exception should not be cause but mapper exception itself.
| } | ||
|
|
||
| @Override | ||
| protected boolean decideRetry(Throwable throwable) { |
Contributor
Author
There was a problem hiding this comment.
Override was missing, so no retry would occur for EMBEDDING_PROVIDER_TIMEOUT.
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes logic for determining retries to actually retry timeouts
Which issue(s) this PR fixes:
Fixes #2392
Checklist