Merged
Conversation
| List<String> cassandraEndPoints(); | ||
|
|
||
| /** Cassandra port (when type is {@link DatabaseType#CASSANDRA}) */ | ||
| @Nullable |
Contributor
Author
There was a problem hiding this comment.
Primitives can never be null
| * defaults to 100 | ||
| */ | ||
| public static final int DEFAULT_MAX_DOCUMENT_INSERT_COUNT = 100; | ||
| int DEFAULT_MAX_DOCUMENT_INSERT_COUNT = 100; |
Contributor
Author
There was a problem hiding this comment.
Interfaces can only have public members and only static fields.
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
| ConsistencyLevel serialConsistency(); | ||
|
|
||
| /** | ||
| * @return Settings for the consistency level. |
Contributor
Author
There was a problem hiding this comment.
Invalid Javadoc; @return only for methods, not classes.
| // TODO: SOME DOCUMENTATION FOR WHAT THIS IS MEANT TO DO!!! | ||
| public interface EmbeddingProvidersConfig { | ||
|
|
||
| // TODO: WHAT IS THE KEY FOR THIS MAP ????? |
Contributor
Author
There was a problem hiding this comment.
Not removed, reordered after "custom" section.
| } | ||
| } | ||
|
|
||
| @ConfigMapping(prefix = "stargate.jsonapi.custom.embedding") |
Contributor
Author
There was a problem hiding this comment.
Not removed, moved next to custom() method
| final AtomicBoolean moreData = new AtomicBoolean(false); | ||
| final String delete = buildDeleteQuery(); | ||
| AtomicInteger totalCount = new AtomicInteger(0); | ||
| final int retryAttempt = retryLimit - 2; |
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
amorton
approved these changes
Feb 12, 2026
Contributor
amorton
left a comment
amorton
left a comment
There was a problem hiding this comment.
looks good, just some nit picks
src/main/java/io/stargate/sgv2/jsonapi/service/operation/collections/ExpressionBuilder.java
Outdated
Show resolved
Hide resolved
...ain/java/io/stargate/sgv2/jsonapi/service/operation/collections/FindCollectionOperation.java
Outdated
Show resolved
Hide resolved
| FailFastInsertException failFastInsertException = (FailFastInsertException) e; | ||
| return failFastInsertException.result; | ||
| }) | ||
| .recoverWithItem(e -> e.result) |
Contributor
There was a problem hiding this comment.
super nit pick: would look nicer if was
.onFailure(FailFastInsertException.class)
.recoverWithItem(FailFastInsertException::result)
Contributor
Author
There was a problem hiding this comment.
Matter of preference I guess... that one is longer :)
Will change.
Contributor
Author
There was a problem hiding this comment.
Hmmmmh. For some reason, that version won't compile. Not sure how/why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes (most) IDE warnings for a package.
Which issue(s) this PR fixes:
N/A
Checklist