Draft
Conversation
…ache-refactor # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/JsonApiStartUp.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/EmbeddingCredentials.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/EmbeddingCredentialsResolver.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/HeaderBasedEmbeddingCredentialsResolver.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/RequestContext.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/RerankingCredentials.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/UserAgent.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/tenant/Tenant.java # src/main/java/io/stargate/sgv2/jsonapi/api/request/tenant/TenantFactory.java # src/main/java/io/stargate/sgv2/jsonapi/api/v1/CollectionResource.java # src/main/java/io/stargate/sgv2/jsonapi/api/v1/KeyspaceResource.java # src/main/java/io/stargate/sgv2/jsonapi/config/DatabaseType.java # src/main/java/io/stargate/sgv2/jsonapi/logging/LoggingMDCContext.java # src/main/java/io/stargate/sgv2/jsonapi/metrics/JsonProcessingMetricsReporter.java # src/main/java/io/stargate/sgv2/jsonapi/metrics/MetricsTenantDeactivationConsumer.java # src/main/java/io/stargate/sgv2/jsonapi/metrics/TenantRequestMetricsFilter.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/CQLSessionCache.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/CqlSessionFactory.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/TenantAwareCqlSessionBuilder.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/executor/CommandQueryExecutor.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/executor/SchemaCache.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/executor/TableBasedSchemaCache.java # src/main/java/io/stargate/sgv2/jsonapi/service/embedding/DataVectorizerService.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/reranking/RerankingMetrics.java # src/main/java/io/stargate/sgv2/jsonapi/service/processor/CommandLog.java # src/main/java/io/stargate/sgv2/jsonapi/service/processor/MeteredCommandProcessor.java # src/main/java/io/stargate/sgv2/jsonapi/service/provider/ModelUsage.java # src/main/java/io/stargate/sgv2/jsonapi/service/reranking/gateway/RerankingEGWClient.java # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/CommandResolver.java # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/CreateCollectionCommandResolver.java # src/main/java/io/stargate/sgv2/jsonapi/util/DynamicTTLCache.java # src/test/java/io/stargate/sgv2/jsonapi/api/request/UserAgentTests.java # src/test/java/io/stargate/sgv2/jsonapi/api/request/tenant/TenantFactoryTests.java # src/test/java/io/stargate/sgv2/jsonapi/api/request/tenant/TenantTests.java # src/test/java/io/stargate/sgv2/jsonapi/service/embedding/operation/EmbeddingGatewayClientTest.java
Yuqi-Du
changed the title
…ache-refactor # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/api/model/command/builders/FilterClauseBuilder.java # src/main/java/io/stargate/sgv2/jsonapi/api/model/command/builders/SortClauseBuilder.java
…UNKNOWN_COLLECTION_OR_TABLE, convert all SchemaObjectName to identifier usage
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
…d log should handle that
Delete @schemaCache and @TableBasedSchemaCache
… schema-refresh event
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
…ache-refactor # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/api/v1/GeneralResource.java # src/main/java/io/stargate/sgv2/jsonapi/api/v1/KeyspaceResource.java # src/main/java/io/stargate/sgv2/jsonapi/exception/ErrorFormatters.java # src/main/java/io/stargate/sgv2/jsonapi/exception/SchemaException.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/executor/SchemaCache.java # src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/executor/TableBasedSchemaCache.java # src/main/java/io/stargate/sgv2/jsonapi/service/embedding/DataVectorizer.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/InsertDBTaskPage.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/InsertOperationPage.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/Operation.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/AlterTypeExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/CreateTableExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/CreateTypeExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/DropIndexExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/DropTableExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/DropTypeExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/KeyspaceDriverExceptionHandler.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tasks/TaskAccumulator.java # src/main/java/io/stargate/sgv2/jsonapi/service/processor/CommandProcessor.java # src/main/java/io/stargate/sgv2/jsonapi/service/processor/MeteredCommandProcessor.java # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/FindRerankingProvidersCommandResolver.java # src/main/resources/errors.yaml # src/test/java/io/stargate/sgv2/jsonapi/api/v1/FindOneIntegrationTest.java # src/test/java/io/stargate/sgv2/jsonapi/api/v1/HttpStatusCodeIntegrationTest.java # src/test/java/io/stargate/sgv2/jsonapi/service/resolver/CommandResolverWithVectorizerTest.java
AlterTableIntegrationTest.shouldDropVectorizeForColumns() was failing because the change to the table schema was not coming through to the API quickly, we rely on the DB to send the change notification. So a single client may not see it's changes immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Major change
Notable points
Which issue(s) this PR fixes:
Fixes #1791
Checklist