Open
Conversation
Contributor
|
I think there is also need to fix "env" versions of these settings:
|
Contributor
Author
Good point, thanks! Fixed. |
amorton
approved these changes
Oct 1, 2025
Contributor
amorton
left a comment
amorton
left a comment
There was a problem hiding this comment.
approved, we can add a comment and ticket about something we are not changing, see comments.
| import io.smallrye.config.WithDefault; | ||
|
|
||
| @ConfigMapping(prefix = "stargate.jsonapi.http") | ||
| @ConfigMapping(prefix = "data-api.http") |
Contributor
There was a problem hiding this comment.
Can we add a comment in ApiConstants that we are leaving the constant as is there and create a ticket to remove the OfflineMode complely, I dont think we use it and we need to check that. It was for the sstable loader.
Contributor
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Replace
stargate.jsonapitodata-apiWhich issue(s) this PR fixes:
Fixes #2209
Checklist