-
Notifications
You must be signed in to change notification settings - Fork 33
Onboard Logs service -instance commands #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
…to feature/onboard-logs-service
| table.AddSeparator() | ||
| table.AddRow("RETENTION DAYS", utils.PtrString(instance.RetentionDays)) | ||
| table.AddSeparator() | ||
| table.AddRow("ACL IP RANGES", utils.PtrString(instance.Acl)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about all the other fields listed in the response of https://docs.api.stackit.cloud/documentation/logs/version/v1#tag/logs/operation/GetLogsInstance? E.g. stuff like datasourceUrl ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently only visible via json output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the table view, I have aligned with the portal's overview when instance is opened. The other infos are grouped under the API tab. For me, these fields would decrease the readability of table view. But if needed, I can add them to table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the missing fields to the table output
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Merging this branch changes the coverage (1 decrease, 8 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
Related to STACKITCLI-292
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)