Skip to content

Conversation

@GokceGK
Copy link
Contributor

@GokceGK GokceGK commented Dec 16, 2025

Description

Related to STACKITCLI-292

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK GokceGK requested a review from a team as a code owner December 16, 2025 15:53
@GokceGK GokceGK marked this pull request as draft December 16, 2025 15:54
@GokceGK GokceGK marked this pull request as ready for review January 7, 2026 11:13
@GokceGK GokceGK enabled auto-merge (squash) January 12, 2026 13:43
table.AddSeparator()
table.AddRow("RETENTION DAYS", utils.PtrString(instance.RetentionDays))
table.AddSeparator()
table.AddRow("ACL IP RANGES", utils.PtrString(instance.Acl))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about all the other fields listed in the response of https://docs.api.stackit.cloud/documentation/logs/version/v1#tag/logs/operation/GetLogsInstance? E.g. stuff like datasourceUrl ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only visible via json output

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the table view, I have aligned with the portal's overview when instance is opened. The other infos are grouped under the API tab. For me, these fields would decrease the readability of table view. But if needed, I can add them to table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the missing fields to the table output

rubenhoenle
rubenhoenle previously approved these changes Jan 26, 2026
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 8 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create 42.19% (+42.19%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete 22.92% (+22.92%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe 71.74% (+71.74%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list 54.17% (+54.17%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update 53.57% (+53.57%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set 90.51% (+0.21%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset 35.25% (-0.05%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/config 70.04% (+0.11%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils 100.00% (+100.00%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go 0.00% (ø) 10 (+1) 0 10 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create/create.go 42.19% (+42.19%) 64 (+64) 27 (+27) 37 (+37) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete/delete.go 22.92% (+22.92%) 48 (+48) 11 (+11) 37 (+37) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe/describe.go 71.74% (+71.74%) 46 (+46) 33 (+33) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/instance.go 0.00% (ø) 8 (+8) 0 8 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list/list.go 54.17% (+54.17%) 48 (+48) 26 (+26) 22 (+22) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update/update.go 53.57% (+53.57%) 56 (+56) 30 (+30) 26 (+26) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/logs.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/config/set/set.go 90.51% (+0.21%) 137 (+3) 124 (+3) 13 👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go 35.25% (-0.05%) 122 (+3) 43 (+1) 79 (+2) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go 90.62% (+0.15%) 64 (+1) 58 (+1) 6 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/client/client.go 0.00% (ø) 1 (+1) 0 1 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils/utils.go 100.00% (+100.00%) 8 (+8) 8 (+8) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants