fix(sqlserverflex): print valid JSON/YAML output for list cmds#1044
Merged
rubenhoenle merged 1 commit intomainfrom Nov 13, 2025
Merged
fix(sqlserverflex): print valid JSON/YAML output for list cmds#1044rubenhoenle merged 1 commit intomainfrom
rubenhoenle merged 1 commit intomainfrom
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Fyusel
approved these changes
Nov 13, 2025
d348c86 to
0e7e89d
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-272 / #893
Testing
stackit beta sqlserverflex instance list-> Expected output:No instances found for project "xxx"stackit beta sqlserverflex instance list --output-format json-> expected valid JSON outputstackit beta sqlserverflex instance list --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex instance create --name my-instance --flavor-id 4.16-Single --storage-size 20export INSTANCE_ID="xxx"stackit beta sqlserverflex instance list-> Expected output: Table showing the available instancesstackit beta sqlserverflex instance list --output-format json-> expected valid JSON outputstackit beta sqlserverflex instance list --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex user list --instance-id $INSTANCE_ID-> Expected output:No users found for instance "my-instance"stackit beta sqlserverflex user list --instance-id $INSTANCE_ID --output-format json-> expected valid JSON outputstackit beta sqlserverflex user list --instance-id $INSTANCE_ID --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex user create --instance-id $INSTANCE_ID --username johndoe --roles "##STACKIT_DatabaseManager##"stackit beta sqlserverflex user list --instance-id $INSTANCE_ID-> Expected output: Table showing the available usersstackit beta sqlserverflex user list --instance-id $INSTANCE_ID --output-format json-> expected valid JSON outputstackit beta sqlserverflex user list --instance-id $INSTANCE_ID --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex database list --instance-id $INSTANCE_ID-> Expected output:No databases found for instance xxx on xxxstackit beta sqlserverflex database list --instance-id $INSTANCE_ID --output-format json-> expected valid JSON outputstackit beta sqlserverflex database list --instance-id $INSTANCE_ID --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex database create my-database --instance-id $INSTANCE_ID --owner johndoestackit beta sqlserverflex database list --instance-id $INSTANCE_ID-> Expected output: Table showing the available databasesstackit beta sqlserverflex database list --instance-id $INSTANCE_ID --output-format json-> expected valid JSON outputstackit beta sqlserverflex database list --instance-id $INSTANCE_ID --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex options --flavors-> Expected output: Table showing the available flavorsstackit beta sqlserverflex options --flavors --output-format json-> expected valid JSON outputstackit beta sqlserverflex options --flavors --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex options --versions-> Expected output: Table showing the available versionsstackit beta sqlserverflex options --versions --output-format json-> expected valid JSON outputstackit beta sqlserverflex options --versions --output-format yaml-> expected valid YAML outputstackit beta sqlserverflex instance delete $INSTANCE_IDChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)