fix(logme): print valid JSON/YAML output for list cmds#1038
Merged
rubenhoenle merged 1 commit intomainfrom Oct 28, 2025
Merged
Conversation
Fyusel
approved these changes
Oct 28, 2025
614104b to
b20b78e
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-264 / #893
Testing
stackit logme instance list-> Expected output: No instances found for project "xxx"stackit logme instance list --output-format json-> Should output valid JSONstackit logme instance list --output-format yaml-> Should output valid YAMLstackit logme instance create --name my-instance2 --plan-name stackit-logme2-1.2.50-replica --version 2stackit logme instance list-> Expected output: Table showing the logme instance(s)stackit logme instance list --output-format json-> Should output valid JSONstackit logme instance list --output-format yaml-> Should output valid YAMLstackit logme credentials list --instance-id $INSTANCE_ID-> Expected output: `No credentials found for instance "my-instance2"stackit logme credentials list --instance-id $INSTANCE_ID --output-format json-> Sould output valid JSONstackit logme credentials list --instance-id $INSTANCE_ID --output-format yaml-> Sould output valid YAMLstackit logme credentials create --instance-id $INSTANCE_IDstackit logme credentials list --instance-id $INSTANCE_ID-> Expected output: Table showing the existing credentialsstackit logme credentials list --instance-id $INSTANCE_ID --output-format json-> Sould output valid JSONstackit logme credentials list --instance-id $INSTANCE_ID --output-format yaml-> Sould output valid YAMLstackit logme plans-> Expected output: A table showing the available plansstackit logme plans --output-format json-> Should output valid JSONstackit logme plans --output-format yaml-> Should output valid YAMLstackit logme instance delete $INSTANCE_IDChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)